Feat: Multi file linking#317
Merged
Merged
Conversation
dapineyro
force-pushed
the
multi-file-linking
branch
from
8272e14 to
cf236ff
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds multi-item linking (files and folders) to interactive sessions across the CLI, enabling both S3 file linking and File Explorer file linking, plus batching and improved user feedback/error messaging. It also updates docs/changelog and removes data linking while resuming a paused session.
Changes:
- Extend linking to support both files and folders (S3 + File Explorer), including batch linking and v2/v1 fallback behavior.
- Enforce session link constraints (100-item cap, duplicate mount-name prevention) and add more actionable mount failure messaging.
- Update CLI help/README/changelog and adjust/expand tests for the new linking behavior.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
cloudos_cli/link/link.py |
Core implementation for multi-item linking, file detection/parsing, duplicate/limit checks, and mount verification/error translation. |
cloudos_cli/link/cli.py |
Updates cloudos link UX/docs and uses the new boolean success signal to exit non-zero on verification failures. |
cloudos_cli/datasets/cli.py |
Updates cloudos datasets link semantics/documentation to allow linking files and relative File Explorer paths. |
cloudos_cli/interactive_session/cli.py |
Updates session creation flow to resolve/link both files and folders, plus duplicate-name handling reuse. |
cloudos_cli/interactive_session/interactive_session.py |
Enhances link-path parsing to distinguish S3 file vs folder and updates display labels. |
tests/test_datasets/test_link.py |
Adjusts existing link tests to account for the new pre-mount status GET checks and parsing changes. |
tests/test_datasets/test_link_files.py |
Adds comprehensive new unit tests for file-level linking, mixed batches, limits, and error translation. |
README.md |
Documents new file/folder linking behavior, relative File Explorer path rules, and the 100-item limit. |
CHANGELOG.md |
Adds v2.91.0 release notes including breaking path-format change and new linking capabilities. |
cloudos_cli/_version.py |
Bumps version to 2.91.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dapineyro
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implement files linking. The CLI can now:
cloudos linkJIRA
LP-107767
Changes
cloudos linkAcceptance Criteria
DEV
Scenario 1 - Successfully link individual S3 file via CLI
Scenario 2 - CLI automatically handles both files and folders
Scenario 3 - Authentication failure handling
Scenario 4 - Authorization failure for file access
Note that the file will appear anyway in the linked data with an error in the UI
Scenario 5 - Private session access control
Scenario 6 - Prevent duplicate file names
Scenario 8 - Cross-platform session type support
Scenario 10 - Backwards compatibility with folder linking
Scenario 11 - Missing required parameters
Scenario 12 - 100 items limit
Scenarios 7 and 9 are missing as they are not feasible as discussed in the ticket here
CLAUDE PR CHECK